Assign integers explicity to enum values corresponding to the plugin API
Sriraman Tallam
tmsriram@google.com
Mon Feb 11 19:04:00 GMT 2013
Forgot to attach the patch last time. Here it is.
On Mon, Feb 11, 2013 at 11:02 AM, Sriraman Tallam <tmsriram@google.com> wrote:
> cc:binutils@sourceware.org
>
> On Mon, Feb 11, 2013 at 11:01 AM, Sriraman Tallam <tmsriram@google.com> wrote:
>> Hi,
>>
>> This patch assigns explicit integers to enum values corresponding
>> to the plugin API. This patch helps preventing problems while
>> cherry-picking plugin-api.h changes from trunk gold to local branches.
>> For instance, a linker plugin compiled with a cherry-picked
>> plugin-api.h header with some enum values missing will behave
>> strangely when used with a linker built with the up to date header.
>>
>>
>> Thanks
>> Sri
-------------- next part --------------
* plugin-api.h (enum ld_plugin_level): Assign integers
explicitly for all values.
Index: include/plugin-api.h
===================================================================
RCS file: /cvs/src/src/include/plugin-api.h,v
retrieving revision 1.20
diff -u -p -r1.20 plugin-api.h
--- include/plugin-api.h 24 Aug 2012 18:35:35 -0000 1.20
+++ include/plugin-api.h 11 Feb 2013 18:51:18 -0000
@@ -358,33 +358,33 @@ enum ld_plugin_level
enum ld_plugin_tag
{
LDPT_NULL = 0,
- LDPT_API_VERSION,
- LDPT_GOLD_VERSION,
- LDPT_LINKER_OUTPUT,
- LDPT_OPTION,
- LDPT_REGISTER_CLAIM_FILE_HOOK,
- LDPT_REGISTER_ALL_SYMBOLS_READ_HOOK,
- LDPT_REGISTER_CLEANUP_HOOK,
- LDPT_ADD_SYMBOLS,
- LDPT_GET_SYMBOLS,
- LDPT_ADD_INPUT_FILE,
- LDPT_MESSAGE,
- LDPT_GET_INPUT_FILE,
- LDPT_RELEASE_INPUT_FILE,
- LDPT_ADD_INPUT_LIBRARY,
- LDPT_OUTPUT_NAME,
- LDPT_SET_EXTRA_LIBRARY_PATH,
- LDPT_GNU_LD_VERSION,
- LDPT_GET_VIEW,
- LDPT_GET_INPUT_SECTION_COUNT,
- LDPT_GET_INPUT_SECTION_TYPE,
- LDPT_GET_INPUT_SECTION_NAME,
- LDPT_GET_INPUT_SECTION_CONTENTS,
- LDPT_UPDATE_SECTION_ORDER,
- LDPT_ALLOW_SECTION_ORDERING,
- LDPT_GET_SYMBOLS_V2,
- LDPT_ALLOW_UNIQUE_SEGMENT_FOR_SECTIONS,
- LDPT_UNIQUE_SEGMENT_FOR_SECTIONS
+ LDPT_API_VERSION = 1,
+ LDPT_GOLD_VERSION = 2,
+ LDPT_LINKER_OUTPUT = 3,
+ LDPT_OPTION = 4,
+ LDPT_REGISTER_CLAIM_FILE_HOOK = 5,
+ LDPT_REGISTER_ALL_SYMBOLS_READ_HOOK = 6,
+ LDPT_REGISTER_CLEANUP_HOOK = 7,
+ LDPT_ADD_SYMBOLS = 8,
+ LDPT_GET_SYMBOLS = 9,
+ LDPT_ADD_INPUT_FILE = 10,
+ LDPT_MESSAGE = 11,
+ LDPT_GET_INPUT_FILE = 12,
+ LDPT_RELEASE_INPUT_FILE = 13,
+ LDPT_ADD_INPUT_LIBRARY = 14,
+ LDPT_OUTPUT_NAME = 15,
+ LDPT_SET_EXTRA_LIBRARY_PATH = 16,
+ LDPT_GNU_LD_VERSION = 17,
+ LDPT_GET_VIEW = 18,
+ LDPT_GET_INPUT_SECTION_COUNT = 19,
+ LDPT_GET_INPUT_SECTION_TYPE = 20,
+ LDPT_GET_INPUT_SECTION_NAME = 21,
+ LDPT_GET_INPUT_SECTION_CONTENTS = 22,
+ LDPT_UPDATE_SECTION_ORDER = 23,
+ LDPT_ALLOW_SECTION_ORDERING = 24,
+ LDPT_GET_SYMBOLS_V2 = 25,
+ LDPT_ALLOW_UNIQUE_SEGMENT_FOR_SECTIONS = 26,
+ LDPT_UNIQUE_SEGMENT_FOR_SECTIONS = 27
};
/* The plugin transfer vector. */
More information about the Binutils
mailing list