[PATCH][GAS][ARM] Fix disassembly of strht

Richard Earnshaw rearnsha@arm.com
Sat Feb 2 14:42:00 GMT 2013


On 01/02/13 15:30, Kyrylo Tkachov wrote:
>> -----Original Message-----
>> From: Richard Earnshaw
>> Sent: 01 February 2013 14:22
>> To: Kyrylo Tkachov
>> Cc: binutils@sourceware.org; nickc@redhat.com
>> Subject: Re: [PATCH][GAS][ARM] Fix disassembly of strht
>>
>> On 01/02/13 11:03, Kyrylo Tkachov wrote:
>>> Hi all,
>>> gas disassembles a form of the strht ARM instruction improperly:
>>>
>>> strht r0, [r1], -r2 @ assembles to E02100B2
>>> @ disassembles as "strh r0, [r1], -r2 ; UNPREDICTABLE"
>>> strht r0, [r1], r2 @ assembles to E0A100B2
>>> @ disassembles as "strh r0, [r1], r2 ; UNPREDICTABLE"
>>>
>>> This patch fixes that. New tests are added for that case, and also
>> for the
>>> similar ldrht instruction.
>>>
>>> Ok for trunk?
>>>
>>> Thanks,
>>> Kyrill
>>>
>>> opcodes/ChangeLog
>>>
>>> 2013-02-01  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>>>
>>> 	* arm-dis.c: Add another pattern for strht.
>>>
>>>
>>> gas/testsuite/ChangeLog
>>>
>>> 2013-02-01  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>>>
>>> 	* gas/arm/archv6t2.s: Add strht and ldrht tests.
>>> 	* gas/arm/archv6t2.d: Add disassembly patterns for the above.
>>>
>>>

OK.

R.




More information about the Binutils mailing list