[buildrobot] nds32: fix disassembler
Jan-Benedict Glaw
jbglaw@lug-owl.de
Fri Dec 13 14:28:00 GMT 2013
Hi!
My build robot found an out-of-range access to one of the array,
caused by two wrongly placed commans:
/bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I/home/jbglaw/repos/binutils_gdb/opcodes -I. -I/home/jbglaw/repos/binutils_gdb/opcodes -I../bfd -I/home/jbglaw/repos/binutils_gdb/opcodes/../include -I/home/jbglaw/repos/binutils_gdb/opcodes/../bfd -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g -O2 -MT nds32-dis.lo -MD -MP -MF .deps/nds32-dis.Tpo -c -o nds32-dis.lo /home/jbglaw/repos/binutils_gdb/opcodes/nds32-dis.c
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I/home/jbglaw/repos/binutils_gdb/opcodes -I. -I/home/jbglaw/repos/binutils_gdb/opcodes -I../bfd -I/home/jbglaw/repos/binutils_gdb/opcodes/../include -I/home/jbglaw/repos/binutils_gdb/opcodes/../bfd -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g -O2 -MT nds32-dis.lo -MD -MP -MF .deps/nds32-dis.Tpo -c /home/jbglaw/repos/binutils_gdb/opcodes/nds32-dis.c -o nds32-dis.o
cc1: warnings being treated as errors
/home/jbglaw/repos/binutils_gdb/opcodes/nds32-dis.c: In function ‘print_insn_nds32’:
/home/jbglaw/repos/binutils_gdb/opcodes/nds32-dis.c:352: error: array subscript is above array bounds
/home/jbglaw/repos/binutils_gdb/opcodes/nds32-dis.c:356: error: array subscript is above array bounds
make[3]: *** [nds32-dis.lo] Error 1
(Cf. http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=59061)
This patch should fix it:
2013-12-13 Jan-Benedict Glaw <jbglaw@lug-owl.de>
* nds32-dis.c (mnemonic_96): Fix typo.
diff --git a/opcodes/nds32-dis.c b/opcodes/nds32-dis.c
index f4bf779..e56a75b 100644
--- a/opcodes/nds32-dis.c
+++ b/opcodes/nds32-dis.c
@@ -228,9 +228,9 @@ print_insn16 (bfd_vma pc, disassemble_info *info, uint32_t insn)
"addri36.sp", "lwi45.fe", "lwi450", "swi450",
"0x1c", "0x1d", "0x1e", "0x1f",
"0x20", "0x21", "0x22", "0x23",
- "0x24", "0x25", "0x26", "0x27,"
+ "0x24", "0x25", "0x26", "0x27",
"0x28", "0x29", "0x2a", "0x2b",
- "0x2c", "0x2d", "0x2e", "0x2f,"
+ "0x2c", "0x2d", "0x2e", "0x2f",
"slts45", "slt45", "sltsi45", "slti45",
"0x34", "0x35", "0x36", "0x37",
"0x38", "0x39", "0x3a", "0x3b",
Ok?
MfG, JBG
--
Jan-Benedict Glaw jbglaw@lug-owl.de +49-172-7608481
Signature of: Alles sollte so einfach wie möglich gemacht sein.
the second : Aber nicht einfacher. (Einstein)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <https://sourceware.org/pipermail/binutils/attachments/20131213/f3357394/attachment.sig>
More information about the Binutils
mailing list