[PATCH 3/5] New target port: Andes 'nds32'. (gas)
nick clifton
nickc@redhat.com
Fri Dec 6 12:13:00 GMT 2013
Hi Kuan-Lin,
There are a few problems with this patch:
1. There is no addition to the assembler documentation.
I would like to see a gas/doc/c-nds32.texi file which includes
documentation for the NDS32 specific command line options, pseudo-ops
and synthetic instructions.
2. There is no testsuite.
There ought to be a gas/testsuite/gas/nds32 directory containing
at least one test, (but preferably a lot more), that checks the assembly
of NDS32 instructions.
3. There is no NEWS announcement.
The file gas/NEWS should be patched to include a sentance
announcing the additon of support for the NDS32.
4. The use of the PTR macro is deprecated.
Please replace all uses of the PTR macro with "void *".
Cheers
Nick
More information about the Binutils
mailing list