[PATCH] gold: pad code segments out to page size for isolate_execinstr targets
Cary Coutant
ccoutant@google.com
Tue Aug 27 21:32:00 GMT 2013
> This makes gold for isolate_execinstr targets (i.e. NaCl targets) pad
> code segments out to the ABI page size with code fill. This brings
> gold in line with what BFD ld does for *-*-nacl* targets after my
> recent change there.
>
> Ok for trunk and 2.23?
This is OK. Thanks!
While I don't think it's a big deal that you can only generate 1-byte
NOPs because of the cache boundary issue, you could have added an
extra parameter to Target::code_fill to provide the address, so that
the target-specific method could use that to figure out what size NOPs
it could generate.
Also, for your purposes, I'd suggest something less benign than NOP
for the code fill -- HCF would be a better choice, don't you think?
-cary
More information about the Binutils
mailing list