GAS REGRESSION: .sleb128 tests

[Julian Brown]

On Fri, 12 Apr 2013 11:58:42 +0100
Nick Clifton <nickc@redhat.com> wrote:

> Hi Julian,
> 
>   I am seeing a lot of new regressions in the GAS testsuites for
> various targets:
> [...]
> Please could you have a look at these failures and either fix the
> tests so that they will work correctly or else arrange to skip the
> tests for the particular targets that are affected.  If you do skip a
> target, please could you add a comment explaining why the test does
> not work on that particular target.

Here's a patch which fixes the targets you listed. Most of the problems
were just assembly syntax (some targets don't seem to like "." for
labels, some targets are fussier about tabs at the start of some
lines). I only needed to skip a test for tic4x and tic54x, since those
don't use 8-bit bytes and that messes up the dump output.

There was a real bug though -- SH does some of its own expression
processing, and that hadn't been modified to take into account the new
bit of precision. The change in the attached patch just mirrors a
similar change in expr.c from the previous patch, and seems to work
fine.

Tested with "make check" for gas for mmix-mmixware, rx-elf, sh-elf,
tic4x-coff, tic54x-coff, xtensa-elf, arm-elf and mips-linux -- all
sleb128 tests now pass.

OK to apply?

Thanks,

Julian

ChangeLog

    gas/
    * expr.c (add_to_result, subtract_from_result): Make global.
    * expr.h (add_to_result, subtract_from_result): Add prototypes.
    * config/tc-sh.c (sh_optimize_expr): Use add_to_result,
    subtract_from_result to handle extra bit of precision for .sleb128
    directive operands.

    gas/testsuite/
    * gas/all/gas.exp (sleb128-7): Don't run for tic4x, tic54x.
    * gas/all/sleb128-2.s: Reformat, use _ at start of labels, remove
    cruft.
    * gas/all/sleb128-3.s: Likewise.
    * gas/all/sleb128-4.s: Likewise.
    * gas/all/sleb128-5.s: Likewise.
    * gas/all/sleb128-7.s: Likewise.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sleb128-target-fixes-3.diff
Type: text/x-patch
Size: 6355 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20130412/dbcf9673/attachment.bin>