[PATCH v2] arm: properly range check immediate operands of VSHL and VQSHL

Richard Earnshaw rearnsha@arm.com
Wed Apr 10 12:36:00 GMT 2013


On 10/04/13 11:45, Jan Beulich wrote:
> These two, other than VQSHLU, didn't have their immediates properly range
> checked so far.
>
> gas/
> 2013-04-10  Jan Beulich <jbeulich@suse.com>
>
> 	* gas/config/tc-arm.c (do_neon_shl_imm): Check immediate range.
> 	(do_neon_qshl_imm): Likewise.
>
> gas/testsuite/
> 2013-04-10  Jan Beulich <jbeulich@suse.com>
>
> 	* gas/arm/neon-addressing-bad.s: Add test for invalid VSHL,
> 	VQSHL, and VQSHLU immediates.
> 	* gas/arm/neon-addressing-bad.l: Update accordingly.
>

neon-addressing-bad is really checking addressing modes for 
loads/stores.  I'd prefer these new checks to be in a separate file; 
perhaps neon-dataproc-bad.

OK with that change.

R.




More information about the Binutils mailing list