[PATCH v2] arm: correct barrier immediate checks

Richard Earnshaw rearnsha@arm.com
Wed Apr 10 12:28:00 GMT 2013


On 10/04/13 11:42, Jan Beulich wrote:
> Both do_barrier() and do_t_barrier() had a bogus constraint() invocation. It
> turns out plain unnecessary, as po_barrier_or_imm() already does the needed
> checking. Since after removing this it became even more obvious that
> do_barrier() and do_t_barrier() are identical, remove the latter at once.
>
> gas/
> 2013-04-10  Jan Beulich<jbeulich@suse.com>
>
> 	* gas/config/tc-arm.c (parse_operands): Re-write
> 	po_barrier_or_imm().
> 	(do_barrier): Remove bogus constraint().
> 	(do_t_barrier): Remove.
>
> gas/testsuite/
> 2013-04-10  Jan Beulich<jbeulich@suse.com>
>
> 	* gas/arm/barrier-bad.d: Change title.
> 	* gas/arm/barrier-bad.s: Add immediate form of ISB and DSB as
> 	well as one symbolic form of DSB.
> 	* gas/arm/barrier-bad.l: Update accordingly.
> 	* gas/arm/barrier-bad-thumb.d: Adjust title. Use barrier.s as
> 	source. Pass -mthumb to gas.

Presumably this should say barrier-bad.s.

> 	* gas/arm/barrier-bad-thumb.l: Remove.
> 	* gas/arm/barrier-bad-thumb.s: Remove.
> 	* gas/arm/barrier-thumb.d: Adjust title. Use barrier.s as source.
> 	Pass -mthumb to gas.
> 	* gas/arm/barrier-thumb.s: Remove.

Otherwise OK.

R.



More information about the Binutils mailing list