[PATCH 04/12] bfd/ * bfd/elf32-microblaze.c: Correct adjustment of global symbols

David Holsgrove david.holsgrove@xilinx.com
Thu Oct 11 05:58:00 GMT 2012


Hi Mike, Michael, All

On 11 October 2012 04:29, Michael Eager <eager@eagercon.com> wrote:
> On 10/10/2012 11:05 AM, Mike Frysinger wrote:
>>
>> On Tuesday 09 October 2012 22:13:57 david.holsgrove@xilinx.com wrote:
>>>
[SNIP]
> Bfd has very little debugging code, but there is an example in bfdwin.c.
> This
> uses a global symbol which can be set by a debugger to enable debug output.
> A
> better method is to enable this by a command line option, but this may not
> be
> as practical for bfd, which is used by several components.
>
> If the debug code is really necessary, it should not require someone
> to modify the file to enable it.
>
> I think that this is development code and is not needed.
>

Yes, this is primarily debug information left over from development,
and I would prefer to remove it from the patch.
I'll update this in the resubmitted patch series.

> --
> Michael Eager    eager@eagercon.com
> 1960 Park Blvd., Palo Alto, CA 94306  650-325-8077
>
>

regards,
David



More information about the Binutils mailing list