[PATCH] MIPS/ld/testsuite: Add missing attribute dump verification

Maciej W. Rozycki macro@codesourcery.com
Thu Nov 29 11:27:00 GMT 2012


Hi,

 While making recent attribute changes I've noticed one of the dumps 
involved was not verified due to a missing keyword.  As a side effect the 
dump itself hadn't been updated along a `readelf' output update a while 
ago.

 The change below addresses both problems, no regressions.  OK to apply?

2012-11-29  Maciej W. Rozycki  <macro@codesourcery.com>

	ld/testsuite/
	* ld-mips-elf/attr-gnu-4-45.d: Add missing "readelf" keyword.  
	Update dump according to current output.

  Maciej

binutils-ld-test-attr-dump-fix.diff
Index: binutils-fsf-trunk-quilt/ld/testsuite/ld-mips-elf/attr-gnu-4-45.d
===================================================================
--- binutils-fsf-trunk-quilt.orig/ld/testsuite/ld-mips-elf/attr-gnu-4-45.d	2012-11-23 20:04:18.000000000 +0000
+++ binutils-fsf-trunk-quilt/ld/testsuite/ld-mips-elf/attr-gnu-4-45.d	2012-11-23 20:20:00.070516447 +0000
@@ -1,9 +1,10 @@
 #source: attr-gnu-4-4.s
 #source: attr-gnu-4-5.s
 #ld: -r
+#readelf: -A
 #warning: Warning: .* uses -mips32r2 -mfp64 \(set by .*\), .* uses unknown floating point ABI 5
 #target: mips*-*-*
 
 Attribute Section: gnu
 File Attributes
-  Tag_GNU_MIPS_ABI_FP: 64-bit float \(-mips32r2 -mfp64\)
+  Tag_GNU_MIPS_ABI_FP: Hard float \(MIPS32r2 64-bit FPU\)



More information about the Binutils mailing list