top-level configure.ac changes lost in sync

H.J. Lu hjl.tools@gmail.com
Thu Nov 15 00:34:00 GMT 2012


I am checking this into GCC tree for Roland.

On Wed, Nov 14, 2012 at 4:13 PM, Roland McGrath <mcgrathr@google.com> wrote:
> I've just noticed that this change (git mirror view):
>
>         commit 7228bb7b806e7f0513557e3002a6dca104a768a1
>         Author: H.J. Lu <hjl.tools@gmail.com>
>         Date:   Sun Aug 26 14:34:38 2012 +0000
>
>             Sync toplevel files with GCC tree
>
> silently reverted my earlier change:
>
>         2012-05-02  Roland McGrath  <mcgrathr@google.com>
>
>                 * configure.ac (ENABLE_GOLD): Consider *-*-nacl* targets ELF.
>                 * configure: Regenerate.
>
> Since my change was approved here and nobody told me otherwise, I did not
> expect that the change had to be made somewhere else to avoid being
> silently clobbered by a blind copying of files from elsewhere.  If verbatim
> copying without regard to divergence is the policy, there should be some
> loud comments at the top of configure.ac and other such files, IMHO.
>
> The patch below restores the wrongly-reverted change.  How do I get this
> in so it won't be clobbered again?
>
>
> Thanks,
> Roland
>
>
> diff --git a/configure b/configure
> index 95828ae..4f77c36 100755
> --- a/configure
> +++ b/configure
> @@ -2951,7 +2951,7 @@ case "${ENABLE_GOLD}" in
>        *-*-elf* | *-*-sysv4* | *-*-unixware* | *-*-eabi* | hppa*64*-*-hpux* \
>        | *-*-linux* | frv-*-uclinux* | *-*-irix5* | *-*-irix6* \
>        | *-*-netbsd* | *-*-openbsd* | *-*-freebsd* | *-*-dragonfly* \
> -      | *-*-solaris2* | *-*-nto*)
> +      | *-*-solaris2* | *-*-nto* | *-*-nacl*)
>          case "${target}" in
>            *-*-linux*aout* | *-*-linux*oldld*)
>              ;;
> diff --git a/configure.ac b/configure.ac
> index c346c2c..4d7bad2 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -316,7 +316,7 @@ case "${ENABLE_GOLD}" in
>        *-*-elf* | *-*-sysv4* | *-*-unixware* | *-*-eabi* | hppa*64*-*-hpux* \
>        | *-*-linux* | frv-*-uclinux* | *-*-irix5* | *-*-irix6* \
>        | *-*-netbsd* | *-*-openbsd* | *-*-freebsd* | *-*-dragonfly* \
> -      | *-*-solaris2* | *-*-nto*)
> +      | *-*-solaris2* | *-*-nto* | *-*-nacl*)
>          case "${target}" in
>            *-*-linux*aout* | *-*-linux*oldld*)
>              ;;



-- 
H.J.



More information about the Binutils mailing list