[PATCH v2] MIPS/GAS: LUI operand handling bug fixes

Maciej W. Rozycki macro@codesourcery.com
Wed Nov 7 22:22:00 GMT 2012


On Wed, 7 Nov 2012, Maciej W. Rozycki wrote:

>  No regressions in testing across the usual MIPS targets.  OK to apply?
> 
> 2012-11-07  Maciej W. Rozycki  <macro@codesourcery.com>
> 
> 	gas/
> 	* config/tc-mips.c (mips_ip) <'u'>: Default to BFD_RELOC_LO16.
> 
> 	gas/testsuite/
> 	* gas/mips/lui.d: New test.
> 	* gas/mips/micromips@lui.d: New test.
> 	* gas/mips/lui-1.l: New list test.
> 	* gas/mips/lui-2.l: New list test.
> 	* gas/mips/lui.s: New test source.
> 	* gas/mips/lui-1.s: New test source.
> 	* gas/mips/lui-2.s: New test source.
> 	* gas/mips/mips.exp: Run the new tests.

 Further testing of an unrelated change revealed that this update is 
needed for ECOFF targets -- I genuinely have no idea why it didn't trigger 
with my earlier testing. :(  Sorry about that.  I have now merged it into 
the original patch and will include it with the final commit.

  Maciej

Index: binutils-fsf-trunk-quilt/gas/testsuite/gas/mips/lui.d
===================================================================
--- binutils-fsf-trunk-quilt.orig/gas/testsuite/gas/mips/lui.d	2012-11-07 22:17:37.731763899 +0000
+++ binutils-fsf-trunk-quilt/gas/testsuite/gas/mips/lui.d	2012-11-07 19:06:42.000000000 +0000
@@ -13,13 +13,13 @@
 [0-9a-f]+ <[^>]*> 3c02000c 	lui	v0,0xc
 [0-9a-f]+ <[^>]*> 3c02000c 	lui	v0,0xc
 [0-9a-f]+ <[^>]*> 3c02000c 	lui	v0,0xc
-[ 	]*[0-9a-f]+: R_MIPS_LO16	\.text
+[ 	]*[0-9a-f]+: (R_MIPS_LO16|REFLO)	\.text
 [0-9a-f]+ <[^>]*> 3c020000 	lui	v0,0x0
-[ 	]*[0-9a-f]+: R_MIPS_LO16	ext
+[ 	]*[0-9a-f]+: (R_MIPS_LO16|REFLO)	ext
 [0-9a-f]+ <[^>]*> 3c020020 	lui	v0,0x20
-[ 	]*[0-9a-f]+: R_MIPS_LO16	\.text
+[ 	]*[0-9a-f]+: (R_MIPS_LO16|REFLO)	\.text
 [0-9a-f]+ <[^>]*> 3c020028 	lui	v0,0x28
-[ 	]*[0-9a-f]+: R_MIPS_LO16	\.text
+[ 	]*[0-9a-f]+: (R_MIPS_LO16|REFLO)	\.text
 [0-9a-f]+ <[^>]*> 3c020000 	lui	v0,0x0
 [0-9a-f]+ <[^>]*> 3c02ffff 	lui	v0,0xffff
 	\.\.\.



More information about the Binutils mailing list