[PATCH] microMIPS/GAS: Unbreak fixed-size delay slot handling

Maciej W. Rozycki macro@codesourcery.com
Thu Nov 1 23:03:00 GMT 2012


On Thu, 25 Oct 2012, Richard Sandiford wrote:

> OK, but:
> 
> "Maciej W. Rozycki" <macro@codesourcery.com> writes:
> > @@ -2315,7 +2326,8 @@ is_delay_slot_valid (const struct mips_o
> >      return TRUE;
> >  
> >    if (mo->pinfo == INSN_MACRO)
> > -    return TRUE;
> > +    return ((history[0].insn_mo->pinfo2 & INSN2_BRANCH_DELAY_16BIT) == 0
> > +	    ? TRUE : FALSE);
> 
> please just use:
> 
>     return (history[0].insn_mo->pinfo2 & INSN2_BRANCH_DELAY_16BIT) == 0;

 I have applied this now (as two separate commits, sorry about that), 
thanks for your review.

  Maciej



More information about the Binutils mailing list