[PATCH] gold: quash unused-param warning in descriptors.cc

Ian Lance Taylor iant@google.com
Thu Nov 1 22:23:00 GMT 2012


On Thu, Nov 1, 2012 at 11:44 AM, Roland McGrath <mcgrathr@google.com> wrote:

>  // Mingw does not define F_SETFD.
>  #ifdef F_SETFD
>    fcntl(fd, F_SETFD, FD_CLOEXEC);
> +#else
> +  (void) fd;
>  #endif
>  }

No, use ATTRIBUTE_UNUSED.  See, e.g., mremap.c.

That patch is preapproved.

Ian



More information about the Binutils mailing list