tic6x testsuite now clean

Alan Modra amodra@gmail.com
Sat May 19 10:40:00 GMT 2012


Today's lucky target to be brought back to zero testsuite fails is
tic6x-elf.  Committed.

gas/
	* config/obj-elf.c (obj_elf_section): Cater for TC_KEEP_OPERAND_SPACES
	targets when checking for "comdat".
gas/testsuite/
	* gas/tic6x/unwind-1.d: Update for readelf changes.
	* gas/tic6x/unwind-2.d: Likewise.
	* gas/tic6x/unwind-3.d: Likewise.
ld/testsuite/
	* ld-elf/elf.exp (note-3.so): xfail tic6x due to non-pic warnings.

Index: gas/config/obj-elf.c
===================================================================
RCS file: /cvs/src/src/gas/config/obj-elf.c,v
retrieving revision 1.145
diff -u -p -r1.145 obj-elf.c
--- gas/config/obj-elf.c	2 Feb 2012 09:26:04 -0000	1.145
+++ gas/config/obj-elf.c	19 May 2012 06:16:37 -0000
@@ -1049,10 +1049,15 @@ obj_elf_section (int push)
 	      group_name = obj_elf_section_name ();
 	      if (group_name == NULL)
 		attr &= ~SHF_GROUP;
-	      else if (strncmp (input_line_pointer, ",comdat", 7) == 0)
+	      else if (*input_line_pointer == ',')
 		{
-		  input_line_pointer += 7;
-		  linkonce = 1;
+		  ++input_line_pointer;
+		  SKIP_WHITESPACE ();
+		  if (strncmp (input_line_pointer, "comdat", 6) == 0)
+		    {
+		      input_line_pointer += 6;
+		      linkonce = 1;
+		    }
 		}
 	      else if (strncmp (name, ".gnu.linkonce", 13) == 0)
 		linkonce = 1;
Index: gas/testsuite/gas/tic6x/unwind-1.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/tic6x/unwind-1.d,v
retrieving revision 1.1
diff -u -p -r1.1 unwind-1.d
--- gas/testsuite/gas/tic6x/unwind-1.d	9 May 2011 13:17:57 -0000	1.1
+++ gas/testsuite/gas/tic6x/unwind-1.d	19 May 2012 06:16:46 -0000
@@ -6,94 +6,94 @@
 Unwind table index '.c6xabi.exidx' .*
 
 0x0: 0x83020227
-  Compact model 3
+  Compact model index: 3
   Stack increment 8
   Registers restored: A11, B3
   Return register: B3
 
 0x100: 0x808003e7
-  Compact model 0
+  Compact model index: 0
   0x80 0x03 pop {A10, A11}
   0xe7      RETURN
 
 0x200: 0x81008863
-  Compact model 1
+  Compact model index: 1
   0x88 0x63 pop {A10, A11, B3, B10, B15}
 
 0x300: 0x83020227
-  Compact model 3
+  Compact model index: 3
   Stack increment 8
   Registers restored: A11, B3
   Return register: B3
 
 0x400: 0x84000227
-  Compact model 4
+  Compact model index: 4
   Stack increment 0
   Registers restored:  \(compact\) A11, B3
   Return register: B3
 
 0x500: 0x80a022e7
-  Compact model 0
+  Compact model index: 0
   0xa0 0x22 pop compact {A11, B3}
   0xe7      RETURN
 
 0x600: 0x84000227
-  Compact model 4
+  Compact model index: 4
   Stack increment 0
   Registers restored:  \(compact\) A11, B3
   Return register: B3
 
 0x700: 0x84000637
-  Compact model 4
+  Compact model index: 4
   Stack increment 0
   Registers restored:  \(compact\) A10, A11, B3, B10
   Return register: B3
 
 0x800: 0x840002d7
-  Compact model 4
+  Compact model index: 4
   Stack increment 0
   Registers restored:  \(compact\) A10, A12, A13, B3
   Return register: B3
 
 0x900: 0x84000c07
-  Compact model 4
+  Compact model index: 4
   Stack increment 0
   Registers restored:  \(compact\) B10, B11
   Return register: B3
 
 0xa00: 0x83ff0027
-  Compact model 3
+  Compact model index: 3
   Restore stack from frame pointer
   Registers restored: A11, A15
   Return register: B3
 
 0xb00: 0x84ff0027
-  Compact model 4
+  Compact model index: 4
   Restore stack from frame pointer
   Registers restored:  \(compact\) A11, A15
   Return register: B3
 
 0xc00: 0x8001c1f7
-  Compact model 0
+  Compact model index: 0
   0x01      sp = sp \+ 16
   0xc1 0xf7 pop frame {B3, \[pad\]}
 
 0xd00: @0x.*
-  Compact model 1
+  Compact model index: 1
   0x01      sp = sp \+ 16
   0xc2 0xf7 0xbf pop frame {\[pad\], A11, B3, \[pad\]}
   0xe7      RETURN
   0xe7      RETURN
 
 0xe00: @0x.*
-  Compact model 1
+  Compact model index: 1
   0x01      sp = sp \+ 16
   0xc2 0xf7 0xfb pop frame {A11, \[pad\], B3, \[pad\]}
   0xe7      RETURN
   0xe7      RETURN
 
 0xf00: @0x.*
-  Compact model 1
+  Compact model index: 1
   0x02      sp = sp \+ 24
   0xc2 0x7f 0xff 0xfb pop frame {A11, \[pad\], \[pad\], \[pad\], \[pad\], B3}
   0xe7      RETURN
Index: gas/testsuite/gas/tic6x/unwind-2.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/tic6x/unwind-2.d,v
retrieving revision 1.1
diff -u -p -r1.1 unwind-2.d
--- gas/testsuite/gas/tic6x/unwind-2.d	9 May 2011 13:17:57 -0000	1.1
+++ gas/testsuite/gas/tic6x/unwind-2.d	19 May 2012 06:16:46 -0000
@@ -6,94 +6,94 @@
 Unwind table index '.c6xabi.exidx' .*
 
 0x0: 0x83020227
-  Compact model 3
+  Compact model index: 3
   Stack increment 8
   Registers restored: A11, B3
   Return register: B3
 
 0x100: 0x808003e7
-  Compact model 0
+  Compact model index: 0
   0x80 0x03 pop {A10, A11}
   0xe7      RETURN
 
 0x200: 0x81008863
-  Compact model 1
+  Compact model index: 1
   0x88 0x63 pop {A10, A11, B3, B10, B15}
 
 0x300: 0x83020227
-  Compact model 3
+  Compact model index: 3
   Stack increment 8
   Registers restored: A11, B3
   Return register: B3
 
 0x400: 0x84000227
-  Compact model 4
+  Compact model index: 4
   Stack increment 0
   Registers restored:  \(compact\) A11, B3
   Return register: B3
 
 0x500: 0x80a022e7
-  Compact model 0
+  Compact model index: 0
   0xa0 0x22 pop compact {A11, B3}
   0xe7      RETURN
 
 0x600: 0x84000227
-  Compact model 4
+  Compact model index: 4
   Stack increment 0
   Registers restored:  \(compact\) A11, B3
   Return register: B3
 
 0x700: 0x84000637
-  Compact model 4
+  Compact model index: 4
   Stack increment 0
   Registers restored:  \(compact\) A10, A11, B3, B10
   Return register: B3
 
 0x800: 0x840002d7
-  Compact model 4
+  Compact model index: 4
   Stack increment 0
   Registers restored:  \(compact\) A10, A12, A13, B3
   Return register: B3
 
 0x900: 0x84000c07
-  Compact model 4
+  Compact model index: 4
   Stack increment 0
   Registers restored:  \(compact\) B10, B11
   Return register: B3
 
 0xa00: 0x83ff0027
-  Compact model 3
+  Compact model index: 3
   Restore stack from frame pointer
   Registers restored: A11, A15
   Return register: B3
 
 0xb00: 0x84ff0027
-  Compact model 4
+  Compact model index: 4
   Restore stack from frame pointer
   Registers restored:  \(compact\) A11, A15
   Return register: B3
 
 0xc00: 0x8001c1f7
-  Compact model 0
+  Compact model index: 0
   0x01      sp = sp \+ 16
   0xc1 0xf7 pop frame {B3, \[pad\]}
 
 0xd00: @0x.*
-  Compact model 1
+  Compact model index: 1
   0x01      sp = sp \+ 16
   0xc2 0xf7 0xbf pop frame {\[pad\], A11, B3, \[pad\]}
   0xe7      RETURN
   0xe7      RETURN
 
 0xe00: @0x.*
-  Compact model 1
+  Compact model index: 1
   0x01      sp = sp \+ 16
   0xc2 0xf7 0xfb pop frame {A11, \[pad\], B3, \[pad\]}
   0xe7      RETURN
   0xe7      RETURN
 
 0xf00: @0x.*
-  Compact model 1
+  Compact model index: 1
   0x02      sp = sp \+ 24
   0xc2 0x7f 0xff 0xfb pop frame {A11, \[pad\], \[pad\], \[pad\], \[pad\], B3}
   0xe7      RETURN
Index: gas/testsuite/gas/tic6x/unwind-3.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/tic6x/unwind-3.d,v
retrieving revision 1.1
diff -u -p -r1.1 unwind-3.d
--- gas/testsuite/gas/tic6x/unwind-3.d	9 May 2011 13:17:57 -0000	1.1
+++ gas/testsuite/gas/tic6x/unwind-3.d	19 May 2012 06:16:46 -0000
@@ -5,7 +5,7 @@
 Unwind table index '.c6xabi.exidx.text.bar' .*
 
 0x0: 0x830e2807
-  Compact model 3
+  Compact model index: 3
   Stack increment 56
   Registers restored: B11, B13
   Return register: B3
@@ -13,6 +13,6 @@ Unwind table index '.c6xabi.exidx.text.b
 Unwind table index '.c6xabi.exidx' .*
 
 0x0: 0x80008021
-  Compact model 0
+  Compact model index: 0
   0x00      sp = sp \+ 8
   0x80 0x21 pop {A10, B3}
Index: ld/testsuite/ld-elf/elf.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elf/elf.exp,v
retrieving revision 1.33
diff -u -p -r1.33 elf.exp
--- ld/testsuite/ld-elf/elf.exp	9 Apr 2012 16:28:34 -0000	1.33
+++ ld/testsuite/ld-elf/elf.exp	19 May 2012 06:16:56 -0000
@@ -66,6 +66,7 @@ if { ![istarget hppa64*-hpux*] } {
 #
 # Only run the test on targets thats support creating shared libraries.
 if { [check_shared_lib_support] } then {
+  setup_xfail "tic6x-*-*"
   run_ld_link_tests {
       {"Build shared library for next test"
        "-shared" "" "note-3.s" {} "note-3.so" }

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list