PATCH: PR ld/14088: Always display addend as signed hex number

H.J. Lu hjl.tools@gmail.com
Sat May 12 01:13:00 GMT 2012


On Fri, May 11, 2012 at 5:47 PM, Hans-Peter Nilsson
<hans-peter.nilsson@axis.com> wrote:
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>> Date: Thu, 10 May 2012 14:54:28 +0200
>
>>       PR ld/14088
>>       * readelf.c (dump_relocations): Always display addend as
>>       signed hex number.
>
> Caused, for cris-elf, gcc -m32:
>
> Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-cris/cris.exp ...
> FAIL: ld-cris/libdso-2
> FAIL: ld-cris/hiddef1
> FAIL: ld-cris/tls-js1
> FAIL: ld-cris/tls-local-63
> FAIL: ld-cris/tls-local-64
>
> Adjusting all test-cases goes along with adjusting readelf.
> Thanks.
>
> brgds, H-P

I checked in this patch.  Sorry for that.

-- 
H.J.
---
diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog
index 63e8f90..d7565b0 100644
--- a/ld/testsuite/ChangeLog
+++ b/ld/testsuite/ChangeLog
@@ -1,5 +1,13 @@
 2012-05-11  H.J. Lu  <hongjiu.lu@intel.com>

+	* ld-cris/hiddef1.d: Updated.
+	* ld-cris/libdso-2.d: Likewise.
+	* ld-cris/tls-js1.d: Likewise.
+	* ld-cris/tls-local-63.d: Likewise.
+	* ld-cris/tls-local-64.d: Likewise.
+
+2012-05-11  H.J. Lu  <hongjiu.lu@intel.com>
+
 	PR binutils/14088
 	* ld-ia64/tlspic.rd: Updated.
 	* ld-x86-64/tlsdesc-nacl.rd: Likewise.
diff --git a/ld/testsuite/ld-cris/hiddef1.d b/ld/testsuite/ld-cris/hiddef1.d
index b3bd87d..1a1cc18 100644
--- a/ld/testsuite/ld-cris/hiddef1.d
+++ b/ld/testsuite/ld-cris/hiddef1.d
@@ -20,7 +20,7 @@ There are 11 section headers, starting at offset 0x[0-9a-f]+:
 #...
 Relocation section '\.rela\.dyn' at offset 0x[0-9a-f]+ contains 1 entries:
 #...
-[0-9a-f]+  0+c R_CRIS_RELATIVE                              [0-9a-f]+
+[0-9a-f]+  0+c R_CRIS_RELATIVE +[0-9a-f]+
 #...
 Symbol table '\.dynsym' contains 6 entries:
 #...
diff --git a/ld/testsuite/ld-cris/libdso-2.d b/ld/testsuite/ld-cris/libdso-2.d
index 165e222..d50cceb 100644
--- a/ld/testsuite/ld-cris/libdso-2.d
+++ b/ld/testsuite/ld-cris/libdso-2.d
@@ -27,7 +27,7 @@ There are 13 section headers.*
 #...
 Relocation section '\.rela\.dyn' at offset 0x[0-9a-f]+ contains 1 entries:
 #...
-00002[12][0-9a-f][048c] +0000000c R_CRIS_RELATIVE +00000150
+00002[12][0-9a-f][048c] +0000000c R_CRIS_RELATIVE +150
 #...
 Symbol table '\.dynsym' contains 4 entries:
  +Num: +Value +Size +Type +Bind +Vis +Ndx +Name
diff --git a/ld/testsuite/ld-cris/tls-js1.d b/ld/testsuite/ld-cris/tls-js1.d
index 0dc4f7c..0c1509f 100644
--- a/ld/testsuite/ld-cris/tls-js1.d
+++ b/ld/testsuite/ld-cris/tls-js1.d
@@ -20,7 +20,7 @@
 #...
 Relocation section '\.rela\.dyn' at offset 0x20c contains 2 entries:
  Offset     Info    Type            Sym\.Value  Sym\. Name \+ Addend
-00002354  0000001e R_CRIS_DTPMOD                                00000000
+00002354  0000001e R_CRIS_DTPMOD +0
 00002364  0000050a R_CRIS_GLOB_DAT   00002368   expobj \+ 0

 Relocation section '\.rela\.plt' at offset 0x224 contains 2 entries:
diff --git a/ld/testsuite/ld-cris/tls-local-63.d
b/ld/testsuite/ld-cris/tls-local-63.d
index ea86a46..320e717 100644
--- a/ld/testsuite/ld-cris/tls-local-63.d
+++ b/ld/testsuite/ld-cris/tls-local-63.d
@@ -10,7 +10,7 @@
 #...
 Relocation section '.rela.dyn' at offset 0x.* contains 1 entries:
  Offset     Info    Type            Sym.Value  Sym. Name \+ Addend
-00002210  0000001c R_CRIS_32_TPREL[ ]+00+
+00002210  0000001c R_CRIS_32_TPREL[ ]+0

 The decoding of unwind sections for machine type Axis Communications
32-bit embedded processor is not currently supported.

diff --git a/ld/testsuite/ld-cris/tls-local-64.d
b/ld/testsuite/ld-cris/tls-local-64.d
index 7630fdc..1ed741c 100644
--- a/ld/testsuite/ld-cris/tls-local-64.d
+++ b/ld/testsuite/ld-cris/tls-local-64.d
@@ -12,7 +12,7 @@
 #...
 Relocation section '.rela.dyn' at offset 0x.* contains 1 entries:
  Offset     Info    Type            Sym.Value  Sym. Name \+ Addend
-00002290  0000001c R_CRIS_32_TPREL[ ]+0+80
+00002290  0000001c R_CRIS_32_TPREL[ ]+80

 The decoding of unwind sections for machine type Axis Communications
32-bit embedded processor is not currently supported.



More information about the Binutils mailing list