PATCH: Preserve the original p_align and p_flags if they are valid

[Doug Kwan (關振德)]

Patch is committed.

http://sourceware.org/ml/binutils-cvs/2012-05/msg00048.html

On Tue, May 8, 2012 at 10:03 AM, Doug Kwan (關振德) <dougkwan@google.com> wrote:
> Thanks for the review. I will commit this for Ben after changing the
> comments since he has not write access.
>
> -Doug
>
> On Tue, May 8, 2012 at 6:41 AM, Alan Modra <amodra@gmail.com> wrote:
>> On Mon, May 07, 2012 at 09:48:58AM -0700, Ben Cheng wrote:
>>> The full context is we run stripped binaries on the target and use
>>> gdbserver to talk to gdb on the host which can access the non-stripped
>>> binaries. However, gdb appears to verify the program headers in memory
>>> against the binary on disk first and will reject the symbols because
>>> of the difference from the PT_GNU_RELRO section:
>>
>> OK, so the real problem is separate debug info.  The patch is OK with
>> the comment change I suggested.
>>
>>> On Mon, May 7, 2012 at 6:03 AM, Alan Modra <amodra@gmail.com> wrote:
>>> > On Fri, May 04, 2012 at 01:59:47PM -0700, Ben Cheng wrote:
>>> >> +          /* Preserve the alignment and flags if they are valid. The gold
>>> >> +             linker generates RW/4 for the PT_GNU_RELRO section. It is better
>>> >> +             for objcopy/strip to honor these attributes otherwise gdb will
>>> >> +             choke when doing cross-debugging. */
>>> >
>>> > I don't see what this has to do with cross-debugging.  Did you mean to
>>> > say "... when using separate debug files."?
>>
>> --
>> Alan Modra
>> Australia Development Lab, IBM