PATCH: PR ld/14052: binutils 2.22.52.0.2 breaks 3.3.x kernel on i686

H.J. Lu hjl.tools@gmail.com
Sat May 5 14:17:00 GMT 2012


On Fri, May 4, 2012 at 9:55 PM, Alan Modra <amodra@gmail.com> wrote:
> On Fri, May 04, 2012 at 10:06:55AM -0700, H.J. Lu wrote:
>> Hi,
>>
>> Fix for
>>
>> http://sourceware.org/bugzilla/show_bug.cgi?id=13621
>>
>> breaks Linux kernel:
>>
>> http://sourceware.org/bugzilla/show_bug.cgi?id=14052
>>
>> This patch reverts the fix for PR 13621 and keeps empty input sections
>> with symbols.  OK to install?
>
> I've reverted the patch for 13621.  We can consider a solution like
> your keeping empty sections with symbols, separately.  No doubt keeping
> empty sections will impact the testsuite if nothing else.
>

I checked in this testcase.

-- 
H.J.
---
diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog
index 534ed0d..ae46fd0 100644
--- a/ld/testsuite/ChangeLog
+++ b/ld/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2012-05-05  H.J. Lu  <hongjiu.lu@intel.com>
+
+	PR ld/14052
+	* ld-elf/pr14052.d: New file.
+	* ld-elf/pr14052.t: Likewise.
+
 2012-05-05  Alan Modra  <amodra@gmail.com>

 	PR ld/14052
diff --git a/ld/testsuite/ld-elf/pr14052.d b/ld/testsuite/ld-elf/pr14052.d
new file mode 100644
index 0000000..dc893a3
--- /dev/null
+++ b/ld/testsuite/ld-elf/pr14052.d
@@ -0,0 +1,8 @@
+#source: start.s
+#ld: -T pr14052.t
+#readelf: -s
+
+#failif
+#...
+ +[0-9]+: +[0-9a-f]+ +0 +(OBJECT|NOTYPE) +GLOBAL +DEFAULT +ABS _data_start
+#...
diff --git a/ld/testsuite/ld-elf/pr14052.t b/ld/testsuite/ld-elf/pr14052.t
new file mode 100644
index 0000000..360c231
--- /dev/null
+++ b/ld/testsuite/ld-elf/pr14052.t
@@ -0,0 +1,11 @@
+SECTIONS {
+	.text : {
+		*(.text)
+	}
+	. = ALIGN (0x1000);
+	.data : {
+		_data_start = .;
+		*(.data)
+	}
+	/DISCARD/ : { *(.*) }
+}



More information about the Binutils mailing list