[patch] ld: optimize vfinfo output slightly

nick clifton nickc@redhat.com
Fri Mar 30 16:20:00 GMT 2012


Hi Mike,

O
>> Write errors should either be handled or ignored, but aborting is not
>> the right thing (it's not an internal error).
>
> so just do something like the following ?
> 	if (fwrite (str, 1, len, fp) != len)
> 	  {
> 	    /* Ignore.  */
> 	  }

Yes.  Although it would be simpler to just remove the whole if (...) 
statment block and just call fwrite without testing its return value.

A patch modified in this way is approved.

Cheers
   Nick



More information about the Binutils mailing list