Commit: Patch: GAS: Fix DWARF line number generation for target that use linker relaxation

nick clifton nickc@redhat.com
Mon Jul 2 07:36:00 GMT 2012


Hi Alan,

> The extra checks are cheap, saving a call to S_GET_VALUE that will
> only return zero anyway (and will save you or me wondering why they
> are done differently some time in the future).

Done.

> You probably ought to look over all the target md_apply_fix functions
> too, for cases where the target does something with fx_subsy and
> doesn't define MD_APPLY_SYM_VALUE as zero.

Agreed - there was one target - msp430 - where this was the case.  I 
have taken care of this as well.

Cheers
   Nick

gas/ChangeLog
2012-07-02  Nick Clifton  <nickc@redhat.com>

	* write.c (fixup_segment): Only perform the subtraction of an
	fx_subsy symbol if MD_APPLY_SYM_VALUE allows it and the symbol is
	properly defined.
	* config/tc-msp430.h (MD_APPLY_SYM_VALUE): Define.



More information about the Binutils mailing list