[gold] PATCH: Support x32 GD->IE and GD->LE optimizations

Ian Lance Taylor iant@google.com
Fri Jan 27 23:23:00 GMT 2012


"H.J. Lu" <hongjiu.lu@intel.com> writes:

> 2012-01-27  H.J. Lu  <hongjiu.lu@intel.com>
>
> 	* x86_64.cc (Relocate::tls_gd_to_ie): Support x32.
> 	(Relocate::tls_gd_to_le): Likewise.


> +      tls::check_tls(relinfo, relnum, rela.get_r_offset(),
> +		     (memcmp(view - 3, "\x48\x8d\x3d", 4) == 0));

The last argument to this memcmp should be 3, not 4.

> +      tls::check_tls(relinfo, relnum, rela.get_r_offset(),
> +		     (memcmp(view - 3, "\x48\x8d\x3d", 4) == 0));

Same here.

This is OK with those changes.

Thanks.

Ian



More information about the Binutils mailing list