68hc11/12/s12x/xgate patch - style question

James Murray jsm@jsm-net.demon.co.uk
Thu Jan 12 19:39:00 GMT 2012


On Tue, 2012-01-10 at 15:45 +0000, James Murray wrote:
> On Tue, 2012-01-10 at 14:41 +0000, nick clifton wrote:
> *) There are some formatting problems.  Ideally we like code that 
> > follows the GNU Coding Standard:
>  

I've read through the document and the main issues as-is are the ones
Nick already highlighted (brace style and space after function name.)

The document mentions that "indent" can apply the desired formatting.
It would be straightforward enough for me to do that, but then the patch
would also include any formatting changes to the existing code which
could obscure that functional changes.

So what do the maintainers prefer? Should the patch be just what I've
changed or should I use indent and reformat the whole of hc11 files I've
touched.

regards

James Murray



More information about the Binutils mailing list