[gold] PATCH: Initial x32 support

[H.J. Lu]

On Fri, Jan 6, 2012 at 3:37 PM, Ian Lance Taylor <iant@google.com> wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>> 2012-01-04  H.J. Lu  <hongjiu.lu@intel.com>
>>
>>       * x86_64.cc: Initial support for x32.
>
>>      local_reloc_may_be_function_pointer(Symbol_table* symtab, Layout* layout,
>>                                       Target_x86_64* target,
>
> When there is a parameter of type Target_x86_64, I think it is clearer
> with your change to write Target_x86_64<size>.  This appears in several
> places, both in declarations and in definitions.  Otherwise the name is
> used both as a template and not, which I think can be confusing.
>
>> +Target_x86_64<size>::Relocate::relocate(const Relocate_info<size, false>* relinfo,
>
> When a function runs past 80 columns as this one does, please start the
> parameters on the next line and indent all of them by four spaces.  See,
> e.g., Target_x86_64::reserve_local_got_entry.  This appears in various
> places.
>
> This patch is OK if you fix those minor issues.
>

Here is the patch I checked in.

Thanks.


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gold-x32-init-2.patch
Type: text/x-diff
Size: 83388 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20120109/77cab339/attachment.bin>