PATCH: PR gold/13507: Gold assumes GOT entry size is the same as ELF class size
Cary Coutant
ccoutant@google.com
Wed Jan 4 00:25:00 GMT 2012
>> 2012-01-03 Cary Coutant <ccoutant@google.com>
>>
>> * gold/incremental.cc (Sized_incremental_binary::do_process_got_plt):
>> Use abstract base class for GOT.
>> * gold/output.h (class Output_data_got_base): New abstract base class.
>> (class Output_data_got): Derive from new base class, adjust ctors.
>> (Output_data_got::reserve_slot): Make virtual; rename to
>> do_reserve_slot; Adjust callers.
>> * gold/target.h (Sized_target::init_got_plt_for_update): Return
>> pointer to abstract base class.
>> * gold/x86_64.cc (Target_x86_64::init_got_plt_for_update): Likewise.
>>
>> + // Reserve a slot in the GOT.
>> + void
>> + reserve_slot(unsigned int i)
>> + { this->do_reserve_slot(i); }
>
> Have the comment explain the meaning of the parameter 'i'.
>
> This is OK with that change.
Done, and committed. Thanks.
HJ, please let me know if this solved your problem.
-cary
More information about the Binutils
mailing list