68hc11/12/s12x/xgate patch
James Murray
jsm@jsm-net.demon.co.uk
Sun Feb 26 23:54:00 GMT 2012
Status update.
On Tue, 2012-01-10 at 14:41 +0000, nick clifton wrote:
> Hi James,
> *) You have included a patch to the top level configure file, but not
> the top level configure.ac file (from which the configure file is
> generated).
I've removed my changes and used the existing build targets.
> *) You have included a patch to the top level config.sub file. Are you
> aware that this patch needs to be submitted to a different project ?
> (config-patches@gnu.org)
I've removed my changes and used the existing build targets.
> *) You have included patches to various ChangeLogs. Common practice is
> just to include changelog entries as plain text, since they almost never
> apply cleanly as patches.
Ready to submit as plain text.
> *) You have added new options to the m68hc11 GAS port, but not added
> documentation for these new options to the gas/doc/c-m68hc11.texi file.
OK, added.
> *) You have added support for a new processor, but not mentioned it in
> either gas/NEWS or ld/NEWS.
OK, added.
> *) There are some formatting problems. Ideally we like code that
> follows the GNU Coding Standard: http://www.gnu.org/prep/standards/
Understood and hopefully now addressed.
I intend to spend some more time reviewing my patch and will re-submit
once I have completed that.
regards
James Murray
More information about the Binutils
mailing list