[Patch, RFC] avoid potential recursion, collect error and warning summaries.

Alan Modra amodra@gmail.com
Tue Feb 21 11:51:00 GMT 2012


On Mon, Feb 20, 2012 at 09:41:03PM +0000, Iain Sandoe wrote:
> Unfortunately, it can't be lightly applied - since the reporting of
> error summary causes a lot of test-cases to need amendment.  Thus
> I've guarded that section of the code, and ports can enable it when
> they have time to go through their test-cases and amend as
> necessary.

I don't like this.  There are quite a lot of generic gas tests that
fail if you define TC_WANTS_ERROR_SUMMARY.  So they will at least need
modifying, and likely duplicating, to suit two possible gas error
behaviours.

If you really think this summary output is desirable, then you will
think it worth spending your time fixing the gas testsuite.  On all
targets.  Anything less is just pushing the job onto Nick, me, or
some other global maintainer since most targets don't really have
active maintainers.

I'm more inclined to recognize we currently have some dead code in
write_object_file and just delete it.

-- 
Alan Modra
Australia Development Lab, IBM



More information about the Binutils mailing list