Performance issue with GNU/ld and DLL

Pascal Obry pascal@obry.net
Fri Feb 10 16:11:00 GMT 2012


Kai,

> So this patch seems to me not ok, as for binary-searching we need to
> make sure list is sorted.

I've reviewed the code and in fact the exports table is update by
def_file_add_export(). This routine insert the items at the good
location, keeping the table sorted.

The only location where the table is updated without using this routine
is in the process_def_file_and_directve line 780 in the section where @
is removed.

  /* Canonicalize the export list.  */
  if (pe_dll_kill_ats)

My patch sort the exports table only in this case and only when needed.

If I have not overlooked some other update the attached patch should be ok.

Comments?

Pascal.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|    http://www.obry.net  -  http://v2p.fr.eu.org
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver keys.gnupg.net --recv-key F949BD3B

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pe-dll.c-auto_export-Use-bsearch-instead-of-linear-s.patch
Type: text/x-diff
Size: 2861 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20120210/91550a1e/attachment.bin>


More information about the Binutils mailing list