[RFC,Patch,AVR]: ad PR13503: Add new relocs to TC_VALIDATE_FIX?

Georg-Johann Lay avr@gjlay.de
Wed Aug 15 07:57:00 GMT 2012


Hi, in gas/config/tc-avr.h there is the following comment
to TC_VALIDATE_FIX:

/* We don't want gas to fixup the following program memory related 
relocations.
    We will need them in case that we want to do linker relaxation.
    We could in principle keep these fixups in gas when not relaxing.
    However, there is no serious performance penilty when making the linker
    make the fixup work.  Check also that fx_addsy is not NULL, in order 
to make
    sure that the fixup refers to some sort of lable.  */

PR13503 introduced new relocs that are not mentioned in TC_VALIDATE_FIX.

The attached patch adds the new BFD_RELOC_AVR_8_LO, BFD_RELOC_AVR_8_HI,
BFD_RELOC_AVR_8_HLO to that exclude list.

I cannot say if these new relocs need to be handled there, if the must
be handled there or must *not* be handled there.  I just noticed that
the new relocs are missing there, but no clue if that's good or bad or
simply does not matter...

Thus please review this patch.  And in the case it is actually needed,
please apply it.


Johann


gas/
	PR 13503
	* config/tc-avr.h (TC_VALIDATE_FIX): Skip: BFD_RELOC_AVR_8_LO,
	BFD_RELOC_AVR_8_HI, BFD_RELOC_AVR_8_HLO.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bin-pr13503-valid-fix.diff
URL: <https://sourceware.org/pipermail/binutils/attachments/20120815/b5b92851/attachment.ksh>


More information about the Binutils mailing list