[PATCH] MIPS/opcodes: Streamline disassembler's operand processing

Maciej W. Rozycki macro@codesourcery.com
Tue Aug 14 23:34:00 GMT 2012


On Tue, 14 Aug 2012, Richard Sandiford wrote:

> > 	* mips-dis.c (print_insn_args): Add GET_OP and GET_OP_S local
> > 	macros, use local variables for info struct member accesses, 
> > 	update the type of the variable used to hold the instruction
> > 	word.
> > 	(print_insn_mips, print_mips16_insn_arg): Likewise.
> > 	(print_insn_mips16): Add GET_OP and GET_OP_S local macros, use 
> > 	local variables for info struct member accesses.
> > 	(print_insn_micromips): Add GET_OP_S local macro.
> > 	(_print_insn_mips): Update the type of the variable used to hold
> > 	the instruction word.
> 
> OK.  Nice cleanup, thanks.

 I've thought so. :)  Applied now, thanks.

 I'll be disappearing for two weeks now.  When I'm back, I'll have a look 
into some outstanding microMIPS stuff that you may remember discussing -- 
the controversial linker relaxation bits.  I hope to get it cleaned up one 
way or another, even if we find no better solution than discarding them 
altogether.

  Maciej



More information about the Binutils mailing list