[PATCH] MIPS: Opcode membership proposal
Maciej W. Rozycki
macro@codesourcery.com
Mon Aug 13 14:56:00 GMT 2012
On Sun, 12 Aug 2012, Richard Sandiford wrote:
> > Hmm, where's the typo? That's supposed to be true as long as the CPU is
> > other than Octeon or the Octeon exclusion bit is zero. Did I get that
> > wrong?
>
> The typo is in the last line I quoted:
>
> >> > + && ((cpu != CPU_OCTEON || ((insn)->exclusions & CPU_OCTEON) == 0)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> CPU_OCTEON is an enum value (6501), not a bitmask value. As I say,
> it looked like it should be "((insn)->exclusions & INSN_OCTEON) == 0"
> instead.
Awww!
> Patch is OK.
And now in, thanks.
Maciej
More information about the Binutils
mailing list