[AArch64] Binutils/gas/ld port for ARM's new 64-bit architecture, AArch64 [5/6] ld changes v2

nick clifton nickc@redhat.com
Thu Aug 9 17:37:00 GMT 2012


Hi Yufeng,

   There is one minor problem with the ld patch:

--- a/ld/Makefile.am
+++ b/ld/Makefile.am
@@ -127,6 +127,10 @@ BFDLIB = ../bfd/libbfd.la
  LIBIBERTY = ../libiberty/libiberty.a

  ALL_EMULATION_SOURCES = \
+	eaarch64elf.c \
+	eaarch64elfb.c \
+	eaarch64linux.c \
+	eaarch64linuxb.c \
  	eaix5ppc.c \
  	eaix5rs6.c \
  	eaixppc.c \


64-bit source files should be added to the ALL_64_EMULATION_SOURCES list 
not the ALL_EMULATION_SOURCES list.  If you build a toolchain configured 
with --enable-targets=all, but *not* configured with --enable-64-bit-bfd 
you will see why this is important.

Otherwise the patches (all of them) look good to me.  If there are no 
other problems raised over the next few days I plan on approving them on 
Monday.

Cheers
   Nick



More information about the Binutils mailing list