gold patch committed: Build fixes for clang

Andrew Pinski pinskia@gmail.com
Thu Apr 26 00:55:00 GMT 2012


On Wed, Apr 25, 2012 at 5:07 PM, Ian Lance Taylor <iant@google.com> wrote:
> I got a report of some warnings building gold with clang.  This patch
> fixes them.  Committed to mainline.

These fixes are not really needed for standard C++ compiler.
Since struct and class are interchangeable there.
I think it was a bad decision on clang's part to say they are different.

Though can you figure out why GCC does not warn/error out about the
do_is_defined_by_abi change?

Thanks,
Andrew Pinski

>
> Ian
>
>
> 2012-04-25  Ian Lance Taylor  <iant@google.com>
>
>        * arm.cc (Target_arm::do_is_defined_by_abi): Make sym a const
>        pointer.
>        (Stub_addend_reader::operator()): Declare Arm_relocate_functions
>        as a class, not a struct.
>        (Target_arm::scan_span_for_cortex_a8_erratum): Likewise.
>        (Target_arm::apply_cortex_a8_workaround): Likewise.
>        * gc.h: Declare Reloc_types as a struct, not a class.
>        * object.h: Declare Symbols_data as a struct.
>        * reloc.h: Declare Read_relocs_data as a struct.
>        * target.h: Declare Relocate_info as a struct.
>
>



More information about the Binutils mailing list