[PATCH] gold/arm: define $a/$d markers in .plt

Cary Coutant ccoutant@google.com
Thu Apr 19 04:45:00 GMT 2012


>> We usually break long lines like this after the '=', and indent the
>> next line 4 spaces:
>
> That's a marked departure from the usual GNU indentation style, which would
> be either what I wrote or breaking the line before the '=' and indenting
> the new line two spaces.  But OK.

Yeah, I'm not sure exactly what the rule is for this particular case
-- there's a mixture of styles in gold, but I think what I described
predominates. I'll defer to Ian to rule on the preferred style.

>> For completeness, we should apply the same treatment to
>> do_define_in_output_segment and do_define_as_constant. It'd be OK with
>> me to defer that to a follow-up patch.
>
> Ok, I'll leave it to you then.  IMHO it would be worthwhile to break out
> the boilerplate of calling the appropriate template flavor of
> define_special_symbol (and now sometimes not) into a common subroutine.

Agreed.

-cary



More information about the Binutils mailing list