[PATCH] make ld-elf/eh[1-4] tests assume less about x86_64 targets
Fri Apr 6 19:10:00 GMT 2012
On Fri, Apr 6, 2012 at 11:39 AM, Roland McGrath <firstname.lastname@example.org> wrote:
> These test cases are written to apply to all x86_64-*-* targets,
> but they assume details of file and address space layout that are
> not true of all targets. This makes them encode their assumptions
> explicitly. Regression tested on x86_64-linux-gnu native, and these
> tests now pass for --target=x86_64-nacl as well.
> Ok for trunk?
> 2012-04-06 Roland McGrath <email@example.com>
> * ld-elf/eh1.d: Add explicit --64 to as options, and explicit
> -melf_x86_64 and -Ttext to ld options, so we don't assume every
> x86_64-*-* target uses --64 (vs --x32) by default or has the
> same address space layout.
> * ld-elf/eh2.d: Likewise.
> * ld-elf/eh3.d: Likewise.
> * ld-elf/eh4.d: Likewise.
Since I wrote them, I guess I can approve their changes. OK.
> * ld-elf/elf.exp: For target *-*-nacl*, use options_regsub(ld) to
> map -melf_x86_64 to -melf_x86_64_nacl.
It looks OK to me. But I can't approve it.
More information about the Binutils