[gold lto patch] Add plugin support for LDPR_PREVAILING_DEF_IRONLY_EXP

Ian Lance Taylor iant@google.com
Mon Sep 26 22:39:00 GMT 2011


Cary Coutant <ccoutant@google.com> writes:

> PS: Is this the right way to put GCC PR tags in a binutils ChangeLog?

There is no right way, this approach seems fine.


> 2011-09-26  Cary Coutant  <ccoutant@google.com>
>
> include/ChangeLog
>
> 	* plugin-api.h (enum ld_plugin_symbol_resolution): Add
> 	LDPR_PREVAILING_DEF_IRONLY_EXP.
> 	(enum ld_plugin_tag): Add LDPT_GET_SYMBOLS_V2.
>
> gold/ChangeLog
>
> 	* plugin.cc (get_symbols_v2): New function.
> 	(Plugin::load): Add LDPT_GET_SYMBOLS_V2.
> 	(is_referenced_from_outside): New function.
> 	(Pluginobj::get_symbol_resolution_info): Add version parameter, return
> 	LDPR_PREVAILING_DEF_IRONLY_EXP when using new version.
> 	(get_symbols): Pass version parameter.
> 	(get_symbols_v2): New function.
> 	* plugin.h (Pluginobj::get_symbol_resolution_info): Add version
> 	parameter.
> 	* testsuite/plugin_test.c (get_symbols_v2): New static variable.
> 	(onload): Add LDPT_GET_SYMBOLS_V2.
> 	(all_symbols_read_hook): Use get_symbols_v2; check for
> 	LDPR_PREVAILING_DEF_IRONLY_EXP.
> 	* testsuite/plugin_test_3.sh: Update expected results.

This is OK.

You need to commit the same change to gcc/include/plugin-api.h, so that
gcc/include/plugin-api.h and src/include/plugin-api.h are identical.

Thanks.

Ian



More information about the Binutils mailing list