gold patch committed: Remove assertion

Ian Lance Taylor iant@google.com
Tue Sep 13 16:17:00 GMT 2011


Jan Kratochvil <jan.kratochvil@redhat.com> writes:

> Hello Ian,
>
> On Mon, 12 Sep 2011 19:35:46 +0200, Ian Lance Taylor wrote:
>> --- object.cc	1 Aug 2011 18:25:21 -0000	1.147
>> +++ object.cc	12 Sep 2011 17:34:11 -0000
>> @@ -1582,8 +1582,6 @@ Sized_relobj_file<size, big_endian>::do_
>>         p != eh_frame_sections.end();
>>         ++p)
>>      {
>> -      gold_assert(external_symbols_offset != 0);
>> -
>>        unsigned int i = *p;
>>        const unsigned char* pshdr;
>>        pshdr = section_headers_data + i * This::shdr_size;
>
> object.cc:1152:23: error: variable ‘external_symbols_offset’ set but not used [-Werror=unused-but-set-variable]

Argh.  Thanks.  Fixed like so.  Committed to mainline.

Ian


2011-09-13  Ian Lance Taylor  <iant@google.com>

	* object.cc (Sized_relobj_file::do_layout): Remove unused local
	variable external_symbols_offset.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: foo.patch
Type: text/x-diff
Size: 1359 bytes
Desc: patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20110913/667cbd60/attachment.bin>


More information about the Binutils mailing list