[gold patch] PR gold/13245: don't treat refs from .so as refs from outside IR

Ian Lance Taylor iant@google.com
Mon Oct 17 23:45:00 GMT 2011


Cary Coutant <ccoutant@google.com> writes:

> 2011-10-17  Cary Coutant  <ccoutant@google.com>
>
> 	PR gold/13245
> 	* gold/plugin.cc (is_visible_from_outside): Check for symbols
> 	referenced from dynamic objects.
> 	* gold/resolve.cc (Symbol_table::resolve): Don't count references
> 	from dynamic objects as references from real ELF files.
> 	* testsuite/plugin_test_2.sh: Adjust expected result.

Please clarify the meaning of the in_real_elf_ field in the definition
in symtab.h.  Currently the comment says "True if we've seen this symbol
in a real ELF object."  This patch seems to change that definition
slightly.

This is OK if you fix the comment.

Thanks.

Ian



More information about the Binutils mailing list