[PATCH, ARM] Fix assembly & disassembly of ARM immediates with explicit rotations

[Julian Brown]

Hi,

This patch (originally by Jie Zhang) fixes assembly and disassembly of
immediates with explicit rotations, and tweaks the expected output of
several tests which use non-canonical immediate representations to
match the revised disassembled output.

Disassembly only uses explicit-rotation syntax if the immediate in
question uses a non-canonical form, i.e. if it does not use a minimal
rotation amount. PLT entries (in particular) use a non-canonical form
of immediate, hence the changes in test output (changing the form of
the PLT entries themselves is, I think, unwise).

OK to apply?

Thanks,

Julian

ChangeLog

    Jie Zhang  <jie@codesourcery.com>
    Julian Brown  <julian@codesourcery.com>

    gas/
    * config/tc-arm.c (parse_shifter_operand): Fix handling
    of explicit rotation.
    (encode_arm_shifter_operand): Likewise.

    gas/testsuite/
    * gas/arm/adrl.d: Adjust.
    * gas/arm/immed2.d: New test.
    * gas/arm/immed2.s: New test.

    ld/testsuite/
    * ld-arm/cortex-a8-fix-b-plt.d: Adjust.
    * ld-arm/cortex-a8-fix-bcc-plt.d: Adjust.
    * ld-arm/cortex-a8-fix-bl-plt.d: Adjust.
    * ld-arm/cortex-a8-fix-bl-rel-plt.d: Adjust.
    * ld-arm/cortex-a8-fix-blx-plt.d: Adjust.
    * ld-arm/ifunc-1.dd: Adjust.
    * ld-arm/ifunc-2.dd: Adjust.
    * ld-arm/ifunc-3.dd: Adjust.
    * ld-arm/ifunc-4.dd: Adjust.
    * ld-arm/ifunc-5.dd: Adjust.
    * ld-arm/ifunc-6.dd: Adjust.
    * ld-arm/ifunc-7.dd: Adjust.
    * ld-arm/ifunc-8.dd: Adjust.
    * ld-arm/ifunc-9.dd: Adjust.
    * ld-arm/ifunc-10.dd: Adjust.
    * ld-arm/ifunc-14.dd: Adjust.
    * ld-arm/ifunc-15.dd: Adjust.
    * ld-arm/ifunc-16.dd: Adjust.

    opcodes/
    * arm-dis.c (print_insn_arm): Explicitly specify rotation
    if needed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: binutils-immediate-rotation-syntax-2.diff
Type: text/x-patch
Size: 61088 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20111013/bc18e271/attachment.bin>