[PATCH ARM/THUMB1] unified syntax MOV with both low register emitting unpredictable code

Thomas Klein th.r.klein@web.de
Tue Nov 15 22:15:00 GMT 2011


On 11/15/11 15:13, Matthew Gretton-Dann wrote:
> On 14/11/11 20:21, Thomas Klein wrote:
>> +        if (low_regs&&  !ARM_CPU_HAS_FEATURE (selected_cpu, 
>> arm_ext_v6t2))
>
> This test is incorrect - you want to check for arm_ext_v6, as all v6 
> variants whether Thumb-1 or Thumb-2 allow low registers in this 
> instruction.
>
>> +          {
>
> Some regression tests would be good here.

Correction and tests attached.
Is this OK.

Regards
   Thomas


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: diff.out
URL: <https://sourceware.org/pipermail/binutils/attachments/20111115/8a8cf809/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ChangeLog
URL: <https://sourceware.org/pipermail/binutils/attachments/20111115/8a8cf809/attachment-0001.ksh>


More information about the Binutils mailing list