[PATCH, MIPS] Fix typo in N64 PLT stub

Richard Sandiford rdsandiford@googlemail.com
Sun Nov 13 10:57:00 GMT 2011


Maxim Kuvyrkov <maxim@codesourcery.com> writes:
> The following patch fixes a typo in N64 PLT stub.  The register move
> that saves return address for dynamic resolver to return to currently
> uses a 32-bit instruction, which truncates upper bits of the return
> address.

Ouch.

> Now, I imagine you would ask why is there a 64-bit address in the PLT
> resolver that only works with 32-bit symbols (aka -msym32).

Nah :-)  The PLT's obviously wrong.  Probably a pasto from the n32 version.

Patch is OK, thanks.  Branch too please, although Tristan plans to
release 2.22 this coming week.

Richard



More information about the Binutils mailing list