[gold patch] Incremental 13/18: Dynamic relocations
Cary Coutant
ccoutant@google.com
Tue May 24 21:44:00 GMT 2011
> I don't mind having Sized_relobj_base when just a couple of things refer
> to it, but it looks wrong when lots of functions use it. The name of a
> class should indicate what sort of thing it is, rather than its position
> in the class heirarchy. We should consider renaming, e.g.,
> Sized_relobj_base => Sized_relobj, Sized_relobj => Sized_relobj_file,
> Sized_incr_relobj => Sized_relobj_incr. I'm open to other suggestions.
Done.
>> + // Create the rela_dyn section.
>> + (void)this->rela_dyn_section(layout);
>
> Drop the "(void)".
Done.
> This is OK with those changes.
Thanks, committed.
-cary
More information about the Binutils
mailing list