Commit: Do not run shared.exp in a cross-build environment

Nick Clifton nickc@redhat.com
Mon May 23 09:13:00 GMT 2011


Hi Guys,

  I am checking in the patch below to revert a change I made last week.
  The library building tests in shared.exp do need a native environment
  in order to be successful, even if they are not going to be executed.

Cheers
  Nick

ld/testsuite/ChangeLog
2011-05-23  Nick Clifton  <nickc@redhat.com>

	* ld-elf/shared.exp: Revert previous delta.  Do not build
	libraries in a non-native environment.

Index: ld/testsuite/ld-elf/shared.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elf/shared.exp,v
retrieving revision 1.16
diff -u -3 -p -r1.16 shared.exp
--- ld/testsuite/ld-elf/shared.exp	18 May 2011 14:04:32 -0000	1.16
+++ ld/testsuite/ld-elf/shared.exp	23 May 2011 09:11:54 -0000
@@ -21,6 +21,13 @@
 
 # Exclude non-ELF targets.
 
+# The following tests require running the executable generated by ld,
+# or enough of a build environment to create a fully linked executable.
+# This is not commonly available when testing a cross-built linker.
+if ![isnative] {
+    return
+}
+
 if ![is_elf_format] {
     return
 }
@@ -154,11 +161,6 @@ set build_tests {
 
 run_cc_link_tests $build_tests
 
-# The following tests require running the executable generated by ld.
-if ![isnative] {
-    return
-}
-
 set run_tests {
     {"Run normal with libfoo.so"
      "tmpdir/begin.o tmpdir/libfoo.so tmpdir/end.o" ""



More information about the Binutils mailing list