[PATCH] C6X unwinding table generation #2

Joseph S. Myers joseph@codesourcery.com
Tue May 3 15:55:00 GMT 2011


On Tue, 3 May 2011, Paul Brook wrote:

> Attached is revised[1] patch to implement C6X unwinding table generation.
> I believe this and the subsequent patch address the issues raised by Joseph 
> last time round.
> 
> Ok?
> 
> Paul
> 
> [1] Original patch: http://sourceware.org/ml/binutils/2011-04/msg00097.html
> 
> 2011-05-03  Paul Brook  <paul@codesourcery.com>
> 
> 
> 	bfd/
> 	* elf32-tic6x.c (elf32_tic6x_howto_table,
[...]

This ChangeLog entry doesn't appear to correspond to the attached patch.

> +  memset(unwind, 0, sizeof(*unwind));

Missing spaces before '(' twice on this line.

> +    case 2: /* B regs.  */
> +      if (reg.num < 16)
> +	return reg.num + 16;
> +      else if (reg.num < 32)
> +	return (reg.num - 16) + 53;
> +      else
> +	return -1;
> +
> +      return reg.num + 16;

This final "return reg.num + 16;" is dead.

> +#define UNWIND_OP2_CANTUNWIND 0x8000

This still appears to be unused (so should be removed).

The patch is OK with those issues fixed.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Binutils mailing list