[RFA/gas] dwarf2dbg.c, plug some memory leaks.

[Michael Snyder]

OK, I'm reverting that change.


Hans-Peter Nilsson wrote:
>> Date: Wed, 09 Mar 2011 12:51:54 -0800
>> From: Michael Snyder <msnyder@vmware.com>
> 
>> 	* dwarf2dbg.c (out_file_list): Free malloced 'dir'.
>> 	(out_debug_info): Free malloced 'dirname' and 'comp_dir'.
> 
> One of your very recent dwarf2dbg.c changes caused my cris-elf
> autotester to buzz.  Given the log message and a brief look in
> that source file, I think it was this one.  (There's more than
> one return in remap_debug_filename.)  The FAILs (well, the
> lns.exp ones) should be visible for other targets.  Host was
> x86_64, F 12.
> 
> Running /tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/cris/cris.exp ...
> FAIL: gas/cris/rd-dw2-1
> FAIL: gas/cris/rd-dw2-10
> FAIL: gas/cris/rd-dw2-11
> FAIL: gas/cris/rd-dw2-12
> FAIL: gas/cris/rd-dw2-13
> FAIL: gas/cris/rd-dw2-14
> FAIL: gas/cris/rd-dw2-15
> FAIL: gas/cris/rd-dw2-2
> FAIL: gas/cris/rd-dw2-3
> FAIL: gas/cris/rd-dw2-4
> FAIL: gas/cris/rd-dw2-5
> FAIL: gas/cris/rd-dw2-6
> FAIL: gas/cris/rd-dw2-7
> FAIL: gas/cris/rd-dw2-8
> FAIL: gas/cris/rd-dw2-9
> ...
> Running /tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/lns/lns.exp ...
> FAIL: lns lns-diag-1
> FAIL: lns-duplicate
> FAIL: lns-common-1
> 
> In gas.log, all FAIL output looks about the same, here's one:
> 
> ../as-new   -o dump.o /tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/lns/lns-duplicate.s
> Executing on host: sh -c {../as-new   -o dump.o /tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/lns/lns-duplicate.s 2>&1}  /dev/null gas.out (timeout = 300)
> *** glibc detected *** ../as-new: free(): invalid pointer: 0xfff426b1 ***
> ======= Backtrace: =========
> /lib/libc.so.6[0xa5bac1]
> /lib/libc.so.6(cfree+0x90)[0xa5f0f0]
> ../as-new[0x804fc03]
> ../as-new[0x805083b]
> ../as-new[0x804c4c6]
> /lib/libc.so.6(__libc_start_main+0xe0)[0xa08390]
> ../as-new[0x80497d1]
> ======= Memory map: ========
> ... (output elided for brevity)
> sh: line 1:  1116 Aborted                 ../as-new -o dump.o /tmp/hpautotest-binutils/bsrc/src/gas/testsuite/gas/lns/ln
> s-duplicate.s 2>&1
> /tmp/hpautotest-binutils/cris-axis-elf/gas/testsuite/../../binutils/readelf  -wl dump.o
> Executing on host: sh -c {/tmp/hpautotest-binutils/cris-axis-elf/gas/testsuite/../../binutils/readelf  -wl dump.o >dump.
> out 2>gas.stderr}  /dev/null  (timeout = 300)
> readelf: Error: dump.o: Failed to read file's magic number
> FAIL: lns-duplicate
> 
> brgds, H-P