[RFA] bfd, elf32-i386.c (elf_i386_relocate_section): Document fall through.
H.J. Lu
hjl.tools@gmail.com
Sun Mar 6 01:37:00 GMT 2011
On Sat, Mar 5, 2011 at 4:57 PM, Michael Snyder <msnyder@vmware.com> wrote:
> There could be a break statement missing here.
> If not, then it is good to comment the fact.
>
> OK?
>
>
> 2011-03-05 Michael Snyder <msnyder@vmware.com>
>
> * elf32-i386.c (elf_i386_relocate_section): Document fall through.
>
> Index: elf32-i386.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elf32-i386.c,v
> retrieving revision 1.242
> diff -u -p -r1.242 elf32-i386.c
> --- elf32-i386.c 6 Jan 2011 18:45:05 -0000 1.242
> +++ elf32-i386.c 6 Mar 2011 00:53:50 -0000
> @@ -3128,7 +3128,7 @@ elf_i386_relocate_section (bfd *output_b
> internal symbol, we have updated addend. */
> continue;
> }
> -
> + /* FALLTHROUGH */
> case R_386_PC32:
> case R_386_PLT32:
> goto do_relocation;
>
>
OK. Thanks.
--
H.J.
More information about the Binutils
mailing list