[PATCH] AMD bdver2 processors 2/2 - TBM

[Quentin Neill]

On Tue, Jan 18, 2011 at 10:35 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Jan 14, 2011 at 2:22 PM, Quentin Neill
> <quentin.neill.gnu@gmail.com> wrote:
>> On Tue, Jan 4, 2011 at 5:02 PM, Quentin Neill
>> <quentin.neill.gnu@gmail.com> wrote:
>>> On Tue, Jan 4, 2011 at 3:00 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>> On Tue, Jan 4, 2011 at 12:26 PM, Quentin Neill
>>>> <quentin.neill.gnu@gmail.com> wrote:
>>>>> On Tue, Dec 28, 2010 at 8:03 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>>> On Tue, Dec 28, 2010 at 5:56 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>>>> On Mon, Dec 20, 2010 at 2:33 PM, Quentin Neill
>>>>>>> <quentin.neill.gnu@gmail.com> wrote:
>>>>>>>> These two patches add support for BMI and TBM ISAs to be introduced in
>>>>>>>> AMD bdver2 processors.
>>>>>>>>
>>>>>>>> The full encoding specification is delayed, however I have posted
>>>>>>>> abbreviated specs on the gcc mailing list:
>>>>>>>> BMI: http://gcc.gnu.org/ml/gcc-patches/2010-10/msg01766.html
>>>>>>>> TBM: http://gcc.gnu.org/ml/gcc-patches/2010-10/msg01767.html
>>>>>>>>
>>>>>>>> Tested on x86-64 with "make -k check RUNTESTFLAGS=i386.exp".
>>>>>>>>
>>>>>>>
>>>>>>> Why is "bextr" in both BMI and TBM?  Please double check you don't have
>>>>>>> instructions in both BMI and TBM.
>>>>>>>
>>>>>>
>>>>>> I see. The TBM one takes an immediate operand.
>>>>>>
>>>>>>
>>>>>> --
>>>>>> H.J.
>>>>>
>>>>> Refreshed with updated Changelogs.
>>>>>
>>>>> Tested on x86-64 with "make -k check RUNTESTFLAGS=i386.exp".
>>>>>
>>>>> Okay to commit?
>>>>
>>>> Didn't you submit a patch with both BMI and TBM?
>>>>
>>>> --
>>>> H.J.
>>>
>>> You are right, Grrrr.
>>> I attached the wrong patch file.
>>> I'll refresh the both patches after addressing objdump feedback you gave.
>>> --
>>> Quentin.
>>>
>>
>> The final TBM patch after merging/rebasing on top of the BMI patch,
>> including tbm-intel.d tests.
>> This passes "make RUNTESTFLAGS=i386 check" (without the k).
>> Okay to commit?
>
> Are you 100% sure that you passed "make RUNTESTFLAGS=i386 check"
> when you committed your change?
>
> --
> H.J.

H.J.,

I wanted to apologize again on the list here for that checkin.  I
bungled the transfer between using GIT in my testing environment
(behind the firewall) and CVS (outside the firewall).  In the past I
relied on Sebastian (and you) to help me catch these beginner errors
but this time I'll admit to being impatient and committing too soon.

Thanks for your reviews, patience and help.

Okay back to hopefully normal (forward progress) development
-- 
Quentin