[toolchain-devel] [Patch] set unused SRCx fields to all 1s for dspalu32 instrs

Jie Zhang jzhang918@gmail.com
Thu Dec 15 04:29:00 GMT 2011


On Sat, Dec 10, 2011 at 11:53 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Thursday 08 December 2011 05:51:30 Henderson, Stuart wrote:
>> --- a/gas/config/bfin-parse.y
>> +++ b/gas/config/bfin-parse.y
>> @@ -166,6 +166,9 @@ char *current_inputline;
>>  extern char *yytext;
>>  int yyerror (char *);
>>
>> +/* Used to set SRCx fields to all 1s as described in the PRM.  */
>> +Register reg7 = {REG_R7, 0};
>
> if we don't need it outside this file, let's mark it static
>
> otherwise, this change looks fine to me ... let's see if Jie has any more
> feedback ...

Good point. The attached patch is what I have committed.

Thank you, Stuart and Mike!

Regards,
Jie
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.diff
Type: text/x-patch
Size: 19348 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20111215/968ddd6f/attachment.bin>


More information about the Binutils mailing list