[Patch] ld testsuite: Fix some FAILs caused by missing -fpic.
David Daney
david.daney@cavium.com
Mon Dec 5 23:52:00 GMT 2011
Since the beginning of time (or at least CVS), there has been special
code in the ld testsuite to omit -fpic from the flags used for building
shared libraries on MIPS. This worked for very old versions of GCC
where the generated code was always PIC by default.
Since GCC-4.3, -fpic has been mandatory for creation of shared objects,
and the testsuite's lack of this flag has caused many test cases to fail.
I propose that we remove this special handling and pass -fpic, just as
we do for almost all other targets. Doing this fixes about twenty FAILs.
Tested on mips64-linux-gnu and x86_64-linux-gnu with no regressions.
OK to commit?
2011-12-05 David Daney <david.daney@cavium.com>
* ld-elfvers/vers.exp (picflag): Remove special handling for mips*-*-*.
(pic): Set to "yes" for mips*-*-linux*.
* ld-elfvsb/elfvsb.exp: Don't test non-PIC shared libraried on
mips*-*-linux*.
( picflag): Remove special handling for mips*-*-*.
* ld-elfweak/elfweak.exp (picflag): Remove special handling
for mips*-*-*.
* ld-shared/shared.exp (picflag): Same.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dd-1.patch
URL: <https://sourceware.org/pipermail/binutils/attachments/20111205/f0b056cc/attachment.ksh>
More information about the Binutils
mailing list