[Patch] fix 4 gas testsuite regressions on aix and alpha-vms

Tristan Gingold gingold@adacore.com
Mon Apr 18 12:58:00 GMT 2011


Hi,

at least two object formats (xcoff and alpha-vms) doesn't put local symbols into the symbols table.
The gas/macros/app* tests regressed on such target because they don't export the symbols.

No regression on i386-linux, 4 regressions fixed on aix and alpha-vms.

Ok for trunk ?

Tristan.

gas/testsuite
2011-04-18  Tristan Gingold  <gingold@adacore.com>

	* gas/macros/app1.s: Export symbol
	* gas/macros/app2.s: Ditto
	* gas/macros/app3.s: Ditto
	* gas/macros/app4.s: Ditto
	* gas/macros/app4b.s: Ditto
	* gas/macros/app1.d: Adjust.
	* gas/macros/app2.d: Ditto.
	* gas/macros/app3.d: Ditto.
	* gas/macros/app4.d: Ditto.

diff --git a/gas/testsuite/gas/macros/app1.d b/gas/testsuite/gas/macros/app1.d
index 51ba9f2..e7f7e1e 100644
--- a/gas/testsuite/gas/macros/app1.d
+++ b/gas/testsuite/gas/macros/app1.d
@@ -1,7 +1,7 @@
 #nm: -n
 #name: APP with macro without NO_APP
 #...
-0+ t a
+0+ T a
 #...
-0+[1-f] t b
+0+[1-f] T b
 #pass
diff --git a/gas/testsuite/gas/macros/app1.s b/gas/testsuite/gas/macros/app1.s
index fd63b81..5cc7a07 100644
--- a/gas/testsuite/gas/macros/app1.s
+++ b/gas/testsuite/gas/macros/app1.s
@@ -1,10 +1,12 @@
 #NO_APP
  .text
  .macro foo
+ .globl a
 a:
  .long 42
  .endm
 #APP
  foo
+ .globl b
 b:
  .long 56
diff --git a/gas/testsuite/gas/macros/app2.d b/gas/testsuite/gas/macros/app2.d
index d6e4ecb..ef62e3a 100644
--- a/gas/testsuite/gas/macros/app2.d
+++ b/gas/testsuite/gas/macros/app2.d
@@ -1,7 +1,7 @@
 #nm: -n
 #name: APP with macro then NO_APP
 #...
-0+ t a
+0+ T a
 #...
-0+[1-f] t b
+0+[1-f] T b
 #pass
diff --git a/gas/testsuite/gas/macros/app2.s b/gas/testsuite/gas/macros/app2.s
index 7147bca..8f9222b 100644
--- a/gas/testsuite/gas/macros/app2.s
+++ b/gas/testsuite/gas/macros/app2.s
@@ -1,11 +1,13 @@
 #NO_APP
  .text
  .macro foo
+ .globl a
 a:
  .long 42
  .endm
 #APP
  foo
+ .globl b
 b:
  .long 56
 #NO_APP
diff --git a/gas/testsuite/gas/macros/app3.d b/gas/testsuite/gas/macros/app3.d
index 671a2fa..4be449c 100644
--- a/gas/testsuite/gas/macros/app3.d
+++ b/gas/testsuite/gas/macros/app3.d
@@ -1,9 +1,9 @@
 #nm: -n
 #name: APP with macro then NO_APP then more code
 #...
-0+ t a
+0+ T a
 #...
-0+[1-f] t b
+0+[1-f] T b
 #...
-0+[2-f] t c
+0+[2-f] T c
 #pass
diff --git a/gas/testsuite/gas/macros/app3.s b/gas/testsuite/gas/macros/app3.s
index 49d850c..7d950c5 100644
--- a/gas/testsuite/gas/macros/app3.s
+++ b/gas/testsuite/gas/macros/app3.s
@@ -1,13 +1,16 @@
 #NO_APP
  .text
  .macro foo
+ .globl a
 a:
  .long 42
  .endm
 #APP
  foo
+ .globl b
 b:
  .long 56
 #NO_APP
+ .globl c
 c:
  .long 78
diff --git a/gas/testsuite/gas/macros/app4.d b/gas/testsuite/gas/macros/app4.d
index b28a17a..537a03b 100644
--- a/gas/testsuite/gas/macros/app4.d
+++ b/gas/testsuite/gas/macros/app4.d
@@ -2,9 +2,9 @@
 #nm: -n
 #name: included file with .if 0 wrapped in APP/NO_APP, no final NO_APP, macro in main file
 #...
-0+ t d
+0+ T d
 #...
-0+[1-f] t a
+0+[1-f] T a
 #...
-0+[2-f] t b
+0+[2-f] T b
 #pass
diff --git a/gas/testsuite/gas/macros/app4.s b/gas/testsuite/gas/macros/app4.s
index ca635bf..1966514 100644
--- a/gas/testsuite/gas/macros/app4.s
+++ b/gas/testsuite/gas/macros/app4.s
@@ -1,9 +1,11 @@
  .text
  .macro foo
+ .globl a
 a:
  .long 42
  .endm
  .include "app4b.s"
  foo
+ .globl b
 b:
  .long 56
diff --git a/gas/testsuite/gas/macros/app4b.s b/gas/testsuite/gas/macros/app4b.s
index 5b2e7af..45e6c4c 100644
--- a/gas/testsuite/gas/macros/app4b.s
+++ b/gas/testsuite/gas/macros/app4b.s
@@ -1,10 +1,12 @@
 #NO_APP
+ .globl d
 d:
  .long 21
 #APP
  .if 0
 #NO_APP
  .err
+ .globl x
 x:
 #APP
  .endif



More information about the Binutils mailing list