[patch binutils]: Add --preprocessor-arg option to windres tool
Nick Clifton
nickc@redhat.com
Mon Apr 11 11:34:00 GMT 2011
Hi Kai,
> This patch adds feature to windres tool, so that user can pass via
> --preprocessor-arg additional options to the preprocessor.
> 2011-04-08 Kai Tietz
>
> * windres.c (usage): Add new --preprocessor-arg option.
> (option_values): Add new OPTION_PREPROCESSOR_ARG enumerator.
> (option long_options): Add preprocessor-arg option.
> (main): Handle it.
The patch itself is OK, but you need to extend it. In particular:
* Document the new option in binutils/binutils.texi.
* Mention the new feature in binutils/NEWS.
* Optional, but very helpful: Add a test to
binutils/testsuite/binutils-all/windres to check that the new feature works.
Cheers
Nick
More information about the Binutils
mailing list